Cory Benfield

Results 1307 comments of Cory Benfield

Can we use `__ANDROID_MIN_SDK_VERSION__` instead, as well as a C shim, to get the APIs to function across both versions?

Yeah, type inference can potentially be made to work here too.

Can you clarify what you expect this to do?

I'm actually not sure whether it will, but the question of how the SecKeyRef is _produced_ is not something this library can help with. The question is, is anything being...

Thanks for filing this. I definitely think now is an appropriate time to revisit this question. I'd like to begin with some fact-finding: what platforms are causing issues with zlib...

> I believe Windows was the main reason I ended up vending zlib, but now that you've made me think it through I remembered that this package doesn't support Windows...

Looks like there are format tweaks that need to happen.

It would probably be enough to apply this diff: ```diff diff --git a/Package.swift b/Package.swift index 0707fe6..7d6d0dd 100644 --- a/Package.swift +++ b/Package.swift @@ -111,7 +111,7 @@ var targets: [PackageDescription.Target] = [...

In what sense are they malformed? Is there a specification for these?

Yeah, I see the change occurred. My question remains: in what sense is this malformed? Is there a specification somewhere of what is valid to put in that box?