Cory Benfield
Cory Benfield
There is a substantial difference between "is a good idea in production code" and "should be used in every example". For example, all production code should use Sessions for everything,...
Yup, I'd be happy to merge a PR with that change in it. :smile:
> Download timeouts should be unlimited by default (people downloading large files). That's not how Requests timeouts work. They apply per socket I/O syscall, not over the total execution time....
All of this is distressingly difficult for us to handle appropriately. The biggest issue is that we do not control header decoding on Python 3 (as noted in the code...
@mjpieters What is the different urlencoding output in each case?
So, just to be clear: when given a byte string in Python 2, the quote library just quotes its bytes directly. When given a unicode string on Python 3, the...
That sounds like it'd be the best approach, if we can swing it.
So this is somewhat reasonable, but made more opaque by the fact that urllib3 gets in the way here. urllib3 will basically always turn a connection setup problem like this...
In 2.7.12: ``` requests.exceptions.ConnectionError: HTTPConnectionPool(host='wowsucherror', port=80): Max retries exceeded with url: / (Caused by NewConnectionError(': Failed to establish a new connection: [Errno 8] nodename nor servname provided, or not known',))...
Basically entirely untouched since originally worked on. 😂