Lucas Kabela

Results 20 comments of Lucas Kabela

Originally, this code ran into the error: ``` Traceback (most recent call last): File "/home/lucaskabela/.conda/envs/cabernet/lib/python3.10/threading.py", line 1016, in _bootstrap_inner self.run() File "/home/lucaskabela/.conda/envs/cabernet/lib/python3.10/threading.py", line 953, in run self._target(*self._args, **self._kwargs) File "/home/lucaskabela/.conda/envs/cabernet/lib/python3.10/site-packages/vllm/v1/engine/core.py",...

> Amazing! I did a bit of refactoring. Things that are missing: > > * Tests in test/test_collectors.py. These should include the vLLMWrapper and the TransformersWrapper > * docstrings +...

cc @BoyuanFeng to review cherrypick conflict resolution

@pytorchbot label "topic: not user facing"

@pytorchmergebot merge -i "Signal not related (cancelled from ci)"

@pytorchmergebot merge -f "Signal not related (cancelled from ci)"

Thanks for feedback - this lgtm now but I will defer to Richard for review