pytorch icon indicating copy to clipboard operation
pytorch copied to clipboard

[Inductor] Fix constants handling for Triton constexpr (triton#8248)

Open jjvraw opened this issue 1 month ago • 2 comments

Up until recently (triton-lang/triton#8248), Triton did not explicitly interpret entries in ASTSource.constants , and Inductor historically treated "non-tensor-like" arguments as constexpr, including runtime scalars. Triton’s updated constexpr handling now requires stricter semantics, so this change restricts constants to arguments marked is_constexpr rather than all “non-tensor-like” arguments.

  • Fixes issue #170049.

jjvraw avatar Dec 07 '25 08:12 jjvraw

:link: Helpful Links

:test_tube: See artifacts and rendered test results at hud.pytorch.org/pr/169782

Note: Links to docs will display an error until the docs builds have been completed.

:heavy_exclamation_mark: 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

:white_check_mark: No Failures

As of commit fbc12c754c3c981bab8fe2912192291a76f7dbaf with merge base 8121f2c5d0dbbee6322c7fadea90729573b85d4d (image): :green_heart: Looks good so far! There are no failures yet. :green_heart:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot[bot] avatar Dec 07 '25 08:12 pytorch-bot[bot]

@pytorchbot label "topic: not user facing"

jjvraw avatar Dec 07 '25 08:12 jjvraw

cc @zou3519 for additional review

Lucaskabela avatar Dec 11 '25 21:12 Lucaskabela

Thanks for feedback - this lgtm now but I will defer to Richard for review

Lucaskabela avatar Dec 12 '25 21:12 Lucaskabela