Luca Cappelletti

Results 234 comments of Luca Cappelletti

> ref. > > https://github.com/gluesql/gluesql/blob/25309dd15a50ee061e714576079b2cd8c1fcca9c/core/src/ast/ddl.rs#L32-L40 > > ColumnDef currently holds information for a single column. Therefore, if we enable composite primary keys, the primary key field should not remain within...

> I believe that with a slight modification to the current structure, particularly the `Schema` and `ColumnDef` structure, we can simplify the code significantly. This could eliminate the need for...

> changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? Could you kindly reference the changes?

> > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > > > > Could you kindly...

> > > > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > > > > >...

> > > > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > > > > >...

> > > > > > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > > >...

> big ones all look great so I think from now, like this, I may suggest some small cleanups or refactoring stuffs. I will leave comments. Ok!

> > > > > > > > changes in `storages/memory_storage/src/{alter_table}|{lib}.rs` does not look related to this PR. could we have this in a different pr? > > > >...

> this is a library project so we should not have any unwrap in the logic codes. using panicable methods in test, surely its good to use that. but not...