Luca Cappelletti

Results 234 comments of Luca Cappelletti

Fortunately, in the SQL parser, I see that the multi-column primary keys are already supported. Hopefully, no edits will be needed there.

In this enum, shouldn't there be more options? https://github.com/gluesql/gluesql/blob/25309dd15a50ee061e714576079b2cd8c1fcca9c/core/src/ast/mod.rs#L43-L46

Where in the code is the unique constraint enforced currently?

@panarch now several storages pass the test suite. How would I go about and test the remaining storage, like redis and IDB storage?

Thanks @panarch ! Now I got to the point of all storages working except for Mongo, which I am very unfamiliar with. I am struggling to understand where it is...

Ok, so I got up until this point where the message I receive from MongoDB is not easy to convert to the error produced by the other endpoints in the...

I have added some tests with selects involving where statements and they are currently failing. Will have to investigate what may be the cause.

> Great start! The initial tests look good. > > Could we also include unit tests in the primary_key planner found [here](https://github.com/gluesql/gluesql/blob/main/core/src/plan/primary_key.rs)? This will help us precisely verify the functionality...

Why is the key of the index, when detected in the query, [only evaluated at this point here](https://github.com/gluesql/gluesql/blob/25309dd15a50ee061e714576079b2cd8c1fcca9c/core/src/executor/fetch.rs#L155)?

Ah I suppose because it can be symbolic in some cases, okay.