Luca Cappelletti

Results 234 comments of Luca Cappelletti

@weiznich I have extended the list of traits to be implemented, please do let me know whether anything is missing.

> From the search linked above it's missing the following impls: > > * `Insertable for Arc/Rc` > > * `Migration for Arc/Rc` > > * `AppearsOnTable for Arc/Rc` >...

I am afraid I will require some more instructions regarding how to proceed. As you can see from the [CI run](https://github.com/diesel-rs/diesel/actions/runs/15212136723/job/42788661444?pr=4610), trying to use `std::rc::Rc` or `std::sync::Arc` in a struct...

> That's kind of expected that this fails as the list of traits as written above is not designed to enable that use-case, but only `Arc/Rc`. If that other things...

Thank you for your reply - regarding extending the `AsExpression` derive, I can try to add the `Rc` and `Arc` derive impls and report how much the compile time increase...

I have approached the `AsExpression` implementation by using [the same approach used for `Cow`](https://github.com/diesel-rs/diesel/blob/efcb1e7e6cc921dbb92edd5fb5a6829c9625da51/diesel/src/type_impls/primitives.rs#L249-L273) and it seems to work appropriately also for `Rc` and `Arc`. If this is correct, there...

I will go through the comments and update the PR accordingly - regarding the Send/Rc issue, should I open an issue in diesel-async on the topic and, after this PR...

I am trying to test and fix the case for `Rc`, but unfortunately this case does not seem to implement Expression: `Rc`. Same thing happens for `Arc`. ```rust #[diesel_test_helper::test] fn...

This issue should likely be closed as PR #2068 has been merged.

Was there any update on the usage of asyncs?