Louis CAD comments

Results 464 comments of


                                            Louis CAD

Update Google accompanist modules

Hello, thanks for the PR. Why did you revert changes to test resources?

Update Google accompanist modules

Thanks for updating! I'll review it soon.

use wrapper tasks, fix #357

Can you undo the changes to the versions.properties files? They are unrelated to the change and make review and history complicated.

use wrapper tasks, fix #357

Using the commit tool window in IntelliJ can help to check what is included in the impeding commit, and uncheck changes or files.

use wrapper tasks, fix #357

@jmfayard Did you try this PR, it did you try something else?

Refactor tasks's name and descriptions

This also works quite well (looking for in-project usages of the `register` extension function for `TaskContainer`. What I like about the current approach is that you can see right in...

Replace duplicated gradle wrappers by symlink and add samples CI check for 6.3+

> how about using the wrapper task instead in the samples? Can you be more specific? I'm not sure how it would be used to avoid duplicates in the repo.

version.properties not persisted

Which version are you using?

0.9.5-dev-009: SNAPSHOT version output and "silent" version.properties updates

> only the explicit call to `refreshVersions` would touch `versions.properties` (except when adding new dependencies). That's already the current behavior. Otherwise, yes, it's planned for #192

Use gradle kotlin script in examples

Among those already using this gradle plugin with Kotlin DSL successfully, does anyone want to edit the `README.md` to add such examples?