refreshVersions icon indicating copy to clipboard operation
refreshVersions copied to clipboard

Published 20 hours ago • verified publisher icon Splitties

Update Google accompanist modules

Open rlatapy-luna opened this issue 2 years ago • 5 comments

rlatapy-luna avatar Jun 28 '22 12:06 rlatapy-luna

Review on Crocodile

crocodile-code-review[bot] avatar Jun 28 '22 12:06 crocodile-code-review[bot]

Hello, thanks for the PR.

Why did you revert changes to test resources?

LouisCAD avatar Jun 28 '22 15:06 LouisCAD

Hello, thanks for the PR.

Why did you revert changes to test resources?

Hello, I thought it was breaking the test 🤔

rlatapy-luna avatar Jun 28 '22 15:06 rlatapy-luna

@rlatapy-luna nope the tests are here to prevent you from typos and so on.

It seems that there are more libraries than what your PR contains. https://mvnrepository.com/search?q=com.google.accompanist

Can you add them too and run the tests please?

jmfayard avatar Jul 02 '22 12:07 jmfayard

Can you add them too and run the tests please?

I added missing accompanist lib and removed deprecated ones (glide & imageloadingCore)

rlatapy-luna avatar Jul 04 '22 07:07 rlatapy-luna

Thanks for updating! I'll review it soon.

LouisCAD avatar Aug 26 '22 22:08 LouisCAD