refreshVersions icon indicating copy to clipboard operation
refreshVersions copied to clipboard

use wrapper tasks, fix #357

Open NikkyAI opened this issue 4 years ago โ€ข 4 comments

๐Ÿš€ Description

removed gradlew/gradle symlinks from sample projects instead added the wrapper task

changed CI to always use the wrappers in plugins/

idea will automatically create the gradlew file and gradle/ folders when linking the gradle projects and also add it to .git/info/exclude (local gitignore) so it will nto commit duplicates ... at least on my systems

๐Ÿ“„ Motivation and Context

fixes #357 symlinks end up as plain files on windows,making it impossible to develop without replacing the symlinks with real files, which messes with git diffs

๐Ÿงช How Has This Been Tested?

๐Ÿ“ฆ Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

โœ… Checklist

NikkyAI avatar Jul 02 '21 17:07 NikkyAI

Can you undo the changes to the versions.properties files? They are unrelated to the change and make review and history complicated.

LouisCAD avatar Jul 02 '21 19:07 LouisCAD

i did not even realize i comitted them accidentally

NikkyAI avatar Jul 02 '21 23:07 NikkyAI

Using the commit tool window in IntelliJ can help to check what is included in the impeding commit, and uncheck changes or files.

LouisCAD avatar Jul 03 '21 10:07 LouisCAD

idea will automatically create the gradlew file and gradle/ folders when linking the gradle projects and also add it to .git/info/exclude (local gitignore) so it will nto commit duplicates

That part doesn't work to me. How is that supposed to work?

jmfayard avatar Jul 10 '22 12:07 jmfayard

Thanks for your work, unfortunately I never got it to work, I guess we can suffer having dupes of those gradle files

jmfayard avatar Sep 05 '22 14:09 jmfayard

@jmfayard Did you try this PR, it did you try something else?

LouisCAD avatar Sep 14 '22 05:09 LouisCAD

now replaced with https://github.com/jmfayard/refreshVersions/pull/626

jmfayard avatar Sep 24 '22 05:09 jmfayard