Louis Brunner comments

Results 151 comments of


                                            Louis Brunner

backend.backend is not a constructor

@cormacrelf `5.0.0-rc02` (and future v5) should address this. You mention a 3.x fix, do you mean the same fix applied on the v3 branch?

Required status check not fulfilled randomly using this action to set the required check

Hi @alambike, I think an optional retry system would be pretty valuable for sure!

details_url not working

Hi @alex-page, Yeah, the whole `action_required` flow doesn't work either from what I can see (which is a huge bummer, you could do such cool stuff with it!) As explained...

details_url not working

> Shouldn't the `details_url` option be removed from the action then? Or at least a warning in the documentation that this feature doesn't actually work? Otherwise people will keep trying...

Not working when multiple workflows are triggered by a commit

Hi @zolex, thanks for your report! What happens if you call the Checks differently? (it looks like both are called "Build Image"?)

Not working when multiple workflows are triggered by a commit

Yeah, looks like it.

Button to manually trigger workflow

Is this similar to #18 or #21 ?

Checks and Workflows conclusion can be different (+ Checks UI is confusing)

Hi @justyn! This is an issue I considered as well when building this action, should it actually fail the workflow when the `conclusion` is not `success`, `action_required` or `neutral`? My...

Checks and Workflows conclusion can be different (+ Checks UI is confusing)

The action is just a wrapper around the GitHub Checks API, so it adds the requested checks with the given information. That is different from the result of a workflow,...

Checks and Workflows conclusion can be different (+ Checks UI is confusing)

Yeah, it is really confusing. I don't personally understand why GitHub shows the Checks sometimes but not other times. It always seems to show on the PR page but not...