Lorsoen

Results 14 comments of Lorsoen

Considering the fact it's only changing the control scheme, I think it's better suited in Conversion, not Fun.

> If things are still legible at 9 then changing it is fine, yes. > > The cutoff was arbitrarily chosen by [@frenzibyte](https://github.com/frenzibyte), intending to be the point where it...

Video to show what I mean, done on a separate branch https://github.com/user-attachments/assets/ac733c44-06cf-4361-9573-f76765789287 (numbs unselected) ![Image](https://github.com/user-attachments/assets/8cc5c0ab-03a6-4798-af0d-bfc2d6d1d313)

First of all, thank you a lot for your detailed review :+1: I've pushed changes to adress the things mentionned (except ones where I'm clueless, see conversations).

> Files outside of t_main.py aren't currently programmatically set up for translation (it is what it is), at the least I think other py files would need a dummy _()...

Working example of a translated char being called from an eternal module (on my french_translation branch, very similar to this one) : https://github.com/user-attachments/assets/80eeb30c-92d5-44d0-892d-9fbe2745d14c

Just noticed this in t_main : ![Copie d'écran_20241013_164748](https://github.com/user-attachments/assets/8ad6c174-bd51-4650-bc7a-190f44bc6c83) This won't work with a lot of languages. Should the plural logic be stripped and the char being something like : "Track(s)"...

I've made a change on localizable strings and the way it handles variable calls. Most of the _prefixes_ (f-string) and _% operators_ were _replaced by ".format"_ instead. (Replacing prefixes was...

One last area that lacks translation is the _default playlist_. I have no idea how to make it translatable, other than _moving the language file loading_ bit before any localizable...

No problem :+1: Should be good to go.