Rhea

Results 29 comments of Rhea

* make sure to shut down your executor service, if running, when the plugin's shutDown is called * don't interrupt the controller thread, this could be either the client thread...

@slyt are you still hoping for a review on this plugin?

Convert this off of draft when you've made the requested changes

Marking as draft for now. Please make the requested changes, then mark the plugin as ready for review.

We decided to change the default for `scoutOverlayInRaid` but not the other. Thanks for the PR!

You should not be loading the resources every frame during render. Load them once and reuse the images between frames https://github.com/lostcoastwizard/skull-prevention-reminder/blob/63643e1df317ee322ffbc844a5947b69327e6538/src/main/java/com/SkullPreventionReminder/SkullPreventionReminderOverlay.java#L31-L40

Is there a reason you need the newer gsheets dependency? Does `v4-rev581-1.25.0`, which is already approved, no longer work?

use slf4j (log.debug) https://github.com/ScreteMonge/creators-kit/compare/809c6b6dc3173ec60feb09719d4b8d742780b14d...ScreteMonge:849594fd02e8e4e13f11f163d8f5e63f8436647a#diff-6d7996798b2952b6e68b75c6202590fe3d65aebf3a24b5967095b62ce4382a76R16 everything else lgtm

To be very clear, this is when using the "Sign out of RuneLite" option added by the Accounts plugin. ![Image](https://github.com/user-attachments/assets/4d27e940-aeed-4405-a69f-e023b9a43951) Since the confirmation JOptionPane takes focus and prevents focus being...