Add PvP Kill Sounds plugin

[slyt]

Play custom sounds when you kill another player or get a killstreak in PvP.

More details in the repo README.

[runelite-github-app[bot]]

New plugin pvp-kill-sounds: https://github.com/slyt/kill-sounds/tree/eb8263b946fd157d2b21bd0918baebc30588abbd

[Nightfirecat]

1. The way you've included your sound resources is not correct; when shipped as a jar, this plugin will not load the default sounds. See: https://github.com/runelite/plugin-hub#plugin-resources. (You should be able to create a shadow jar for your plugin, move that jar to any directory, and have it load the sound resources from the jar, rather than from your filesystem)
2. We're not comfortable distributing some of the more aggressive sounds ("get fucked", "eat shit and die" primarily), please remove and/or replace them as needed. Thanks!

[slyt]

@Nightfirecat I removed the profane sounds (https://github.com/slyt/kill-sounds/commit/eb8263b946fd157d2b21bd0918baebc30588abbd). I'm still figuring out how to generate a shadow jar, any advice would be much appreciated.

For some reason I was hit with a botting temp ban last night when I booted up my client to work on this. When I first loaded the client I was warned that it was out of date. I wasn't sure how to update it in the context of developing my addon. Could an out out of date client have caused my account to be flagged? I'm scared to continue developing this due to the threat of a perma ban on my 20+ year old account...

Is there any info I can provide or look at to indicate a bad build? I'm building in Ubuntu with VSCode which is probably non-standard. From this reddit post it seems Jagex is looking at modified RL clients to trigger bans. I've submitted an appeal, so hopefully it gets cleared up.

[slyt]

I reached out on Discord for help but nobody seemed to know what could be the cause of the ban and people were understandably suspicious in thinking that I actually botting. So now my goal is the understand the Java build process in more detail and replicate a ban with my build environment on a junk account. Hopefully I can shed some light on the situation to prevent future novice developers from getting false bans.

Some things I'll be testing out to see if false ban is triggered:

• Using outdated Runelite version (I have a hunch my cache was stale from not developing for over a month)
• Building on Ubuntu
• Building with Gradle vs Maven
• Building with VSCode vs IntelliJ
• Inclusion of external dependencies
• Building with different Java Versions

[Nightfirecat]

Sorry for the late response, I've been quite busy this past month. You should be able to follow the steps below to generate a shadow jar:

Add the following line to your plugins block in build.gradle:

id "com.github.johnrengelman.shadow" version "6.1.0"

Add this block elsewhere in the file, changing the Main-Class to your plugin's test:

shadowJar {
 from sourceSets.test.output
 configurations = [project.configurations.testRuntimeClasspath]
 manifest {
 attributes "Main-Class": "com.example.ExamplePluginTest"
 }
}

Then run ./gradlew shadowJar and a runnable jar will appear in build/libs/*-all.jar. You can run the jar with java -jar -ea jarName.jar

[LlemonDuck]

@slyt are you still hoping for a review on this plugin?

[Nightfirecat]

Closing this PR due to inactivity, please feel free to re-open it later if you plan to make the needed changes.