Fabian Franz

Results 88 comments of Fabian Franz

``` diff --git a/example/unpfs/src/main.rs b/example/unpfs/src/main.rs index ccd5deb..34f3b2f 100644 --- a/example/unpfs/src/main.rs +++ b/example/unpfs/src/main.rs @@ -22,6 +22,8 @@ use { mod utils; use crate::utils::*; +use std::convert::TryInto; + // Some clients will incorrectly...

@taz77 That's great to hear. The most active maintainer is @WengerK right now. I would say the process would be to make some pull requests (with passing tests -- if...

Seems this needs a little bit more work to be ready :)

Thank you very much, that is a cool thing! :)

drupal_ti is module, which means you can just define a .before directory then add: .drupal_ti/before/runners/simpletest/script.sh and there you can change your code to use: ``` if [ "${TRAVIS_PULL_REQUEST}" = "false"...

Any concrete suggestion on how to make this better?

I think I could just check for COMPOSER_BIN_DIR instead? Then it would continue to work. This is mainly for the installation, so not affecting other parts.

As drupal_ti takes care of installing drush and there is no harm in doing so, I think checking COMPOSER_BIN_DIR is enough. It is an edge-case anyway - as hhvm has...