Fabian Franz

Results 88 comments of Fabian Franz

Thanks for the bug report. I will look into that!

index-perf.php is supposed to also work when xhprof is not installed. This is useful for ab style testing without having apache in between, but the raw PHP performance, which is...

Great idea! I wanted LRU for APCu since quite a long time.

It works locally, @beberlei :) Good idea to rely on upstream.

We unfortunately need a README.md update for that, too.

I am not the author, but I saw two things in the code: - a) You need to fill up to limit and not up to 1,num (So limit -...

I think this is a great addition for ddev-contrib. I followed the recipe and it works! For core ddev I think we need something more streamlined (e.g. no mongo and...

This is how I solved this for Drupal: https://github.com/LionsAd/opentelemetry-auto-drupal/blob/drupal-instrumentation--mega-pack/src/DrupalAutoRootSpan.php#L19-L25 as long as you have a class, which is constructed way early after the autoloaded classes, you can create the auto...

Test are failing, so I aborted my review: ``` 1. Line 172: Trying to destructure goose_metrics.transactions.iter() as tuples, but it's actually Vec 2. Line 192: Using final_users field that doesn't...

Here is the clippy diff - it must be my version, which is still overly pedantic, but I also find it easier to read: ``` diff --git i/src/metrics/common.rs w/src/metrics/common.rs index...