Linus Unnebäck comments

Results 747 comments of


                                            Linus Unnebäck

Use the built-in Modal component from React Native

friendly ping @jacklam718 ☺️ Our app isn't suffering from #150 without this, would be great to get this merged and a new release cut 👍

Use the built-in Modal component from React Native

No worries! From reading around the links from the issue, I think that this has actually been solved in a later version of react-native. To be absolutely sure I tested...

tzdb support

Something to keep an eye on/draw inspiration from is https://github.com/unicode-org/icu4x/issues/1003 which is the tracking issue for `ZonedDateTime` in icu4x. It draws inspiration from the [TC39 Temporal standard](https://tc39.es/proposal-temporal/docs/) which I've personally...

For loops declaration sometimes shadows loop condition variables

Created a repo with minimal reproduction 👉 [LinusU/babel-minify-for-loop-issue](https://github.com/LinusU/babel-minify-for-loop-issue)

Web support

I don't think that this is stale, but it seems like this is already working. Could we get this added to the readme?

remove require('url') in favor of URL

I wanted to land this so rebased on master. Unfortunately, this was harder than I thought! Since the current API allows passing any different combinations of options that is being...

Added support for JSON fields for parity with Axios;

I'm sorry, but I still feel that this is out of scope for Multer. If this is something that more clients than Axios implements (especially if `fetch` implements it) I'd...

DoS vulnerability from [email protected]

@bryanph there is already another `2.0` release line with multiple releases @ZhaoKunLong @ashish1497 yes, `npm i [email protected]` should fix this 👍

Error too many parts after upgrading from 1.4.4 to 1.4.5-lts.1

Nice catch, that looks like it 👍

having a custom middleware that adds a req.on('data', (chunk)->{ //manipulate some data from chunk }), doesn't allow multer to generate the file filed on req.

This is because attaching attaching a data listener will make data start flowing, and since this is before the stream gets passed to Multer my guess is that the first...