Linus Unnebäck

icon indicating a website link https://linusu.se icon indicating an email [email protected]

icon company @locoapp @ctrl-alt-deseat icon location Stockholm, Sweden

Results 747 comments of Linus Unnebäck

Proposal: Move the "feature" of standardx into standard

@JeffSpies for TypeScript, I think that use case is better served by `ts-standard`, until we potentially can merge that into `standard`. Have you tried `ts-standard`? ☺️

max-statements-per-line: 2

Personally leaning against this because of the "magic number" argument

The "no-irregular-whitespace" rule prevents proper typography in comments outside English.

> despite the "space before function decl/expr opening parens" rule, which I find fugly. One very nice thing is that you can search your codebase for the definition of the...

Consider adding `eslint-plugin-unicorn`

`"unicorn/filename-case": ["error", {"case": "kebabCase"}]` 😍

Consider adding `eslint-plugin-unicorn`

Still think this is relevant 👍

Add catch-or-return

Ecosystem breakage report: - [ ] [`fs-extra`](https://github.com/jprichardson/node-fs-extra) - `lib/copy/copy.js:54:3` - [ ] [`simple-peer`](https://github.com/feross/simple-peer) - `index.js:701:7` - [ ] [`standard-engine`](https://github.com/standard/standard-engine) - `bin/cmd.js:95:5` - [ ] [`webtorrent`](https://github.com/webtorrent/webtorrent) - `lib/file.js:109:5` - `lib/file.js:118:5` -...

Add catch-or-return

I'm not too sure about this, from the discussion in https://github.com/jprichardson/node-fs-extra/pull/622 it seems like there isn't really a straight forward way to work around this. I think that we should...

Enforce more indentation rules

I've seen `1` used more, and I think that is what I personally prefer...

Some logo images are hard to see in dark mode on GitHub

Maybe better is to add white outline on the ones that needs it, so that we don't get the jarring white boxes. e.g. the npm logo would look good if...

Async iterator patterns

Thank you for sharing! I wonder if we should also report this upstream to eslint, maybe the rule should be modified to allow async loops. Currently this is not documented...