Leon Talbert
Leon Talbert
@nazarhussain Thanks very much for your feedback, will tighten up the code, address your comments and move this out of WIP/Draft shortly.
> Hi, @LeonmanRolls , will you have time for discussion or addressing feedback of this PR? Thanks Hi yes sure I will address your feedback sorry for the delay, i...
> I would second @jdevcs feedback. We should not introduce new package `web3-http` instead use existing `web3-providers-http` package. You can create a private instance of the provider and use `.send`...
> Hi @LeonmanRolls Thanks for your contributions in web3.js , could you remove package lock files from this PR: > > * package-lock.json > * packages/web3-ccip-read/package-lock.json > * packages/web3-http/package-lock.json >...
Hi @jdevcs @nazarhussain I have moved the network request code to be part of the provider now. I have also added in wildcard resolution as described here: https://docs.ens.domains/ens-improvement-proposals/ensip-10-wildcard-resolution. They work...
Hi @GregTheGreek , I've moved the logic for CCIP-Read into the web3-core-method package (as a separate file) as that's the only place it's used at the moment, and including it...
Will submit a corresponding PR for v4
np, thanks for play-clj :) Sure I'll finish off the public methods in core for this PR and then hopefully go namespace by namespace.
Okay think this is ready to merge! Tested the tutorial game with instrumentation on and had no problems.