Leon Hornich

Results 13 comments of Leon Hornich

Hi @LaurenceKuhl do you know if someone can help me out with this? I still think that the template update messed up some things and I have been unable to...

> It's looking good! I left some comments and suggestionts. Could you provide a screenshot of an example result? It would also be good to add it to the documentation....

Hi @mirpedrol , I finally had some time and took care of your suggestions. Should be mostly done by now. Turns out I originally had some python code formatter installed...

> looking at the failing tests. Does this PR change something in the `multiqc_fastqc.txt` file? It shouldn't, I am a little clueless as for why this is not passing

> I re-run the tests and it seems to be consistent, so I would suggest to update the failing snapshots with the md5 that we see here 🤞 How and...

Hmm, seems like similar tests are failing here https://github.com/nf-core/crisprseq/pull/247 . So something on the dev branch might not be working?

> Hi @LeonHornich, I solved the issue in #247 by skipping the "unstable" files in the snapshot. When we merge the code from that PR you can update your branch...

Looks like everything passed. Thank you again @matbonfanti 👏🏻

I don't have permissions to merge this pr. Maybe @mirpedrol can do it? Thank you everyone, we can finally close this pr :)

Hi, i am new to this and have mostly been following the bytesize talk. How do i add stub tests? I have found https://nf-co.re/docs/tutorials/nf-core_components/components but I am still a bit...