Benjamin Sutas
Benjamin Sutas
@BartoszKedziorek my pleasure, thanks for a great feature and nice PR. Just a quick note for future PRs, after it's merged you can update the milestone to the next release...
> I believe only maintainers can do this, fwiw. Oh I didn't realise, sorry! I'm happy to add the versions anyways
My first impression is that this would require the new save format for you to save these 'zones'. Then you'd need to write the code and gui to allow you...
still wanna clean this up a bit since i did this on the laptop, but it appears to work
made the changes duncan requested, ready to review again
> Before merging, could you add a changelog entry stating the title screen music is now bound to the music volume setting, or some such? Will do, I'm so bad...
Scope for this change would be these windows (screenshot from ShortcutManager.cpp) 
Expanded scope for this to all windows with keybinds in the game, ie the build windows and terraform windows, and news and messages.
what do we need to do for this one? more testing?
> > what do we need to do for this one? more testing? > > Yes pretty much. I'm afk for the week so I'm unable to do it till...