Wei Lee comments

Results 482 comments of


                                            Wei Lee

[feature request] proposal order in review system

Thanks for working on this issue! 🙂 It seems item 1, and 3 are now in `https://tw.pycon.org/2020/zh-hant/reviews/?order=count` We still have item 2 to go. 🚀

Feature/allow empty commit

I'm kinda not sure whether this is correctly tested and will need sometime to figure it out. Will try to check it this week

Report hook installation fail

> I found that TestPreCommitCases has some duplicated code. Should they be extracted to methods? Yep that would be great

cz check range sometimes failed in GitLab CI

Is it possible that the git repo doesn't setup remote 🤔

cz check range sometimes failed in GitLab CI

Hmmm... As I'm not able to reproduce it, I don't have any clue on how we could fix it. But we can keep it open till you or someone encounter...

cz check range sometimes failed in GitLab CI

Do you mean after merging back to the master branch? If that's the case, your `HEAD` will on on `master` so the result seem to be expected.

cz check range sometimes failed in GitLab CI

@SsuperL Please try `cz --no-raise 3 check --rev-range master..`. it's output the message with a zero return code https://commitizen-tools.github.io/commitizen/bump/#easy-way

tag message for annotated_tag option

Hi @frerksaxen , thanks for the feedback. I'm afraid I did not get the point. Could you please add some examples so that we could take a look?

Discussion on check-consistency

Thanks for your report! I've verify this error on my local machine

Discussion on check-consistency

In the current design, we're not able to check inconsistency with the same format in the same file. (e.g., `pyproject:__version__` can be interpret as the one in poetry section or...