commitizen icon indicating copy to clipboard operation
commitizen copied to clipboard

Feature/allow empty commit

Open Dranaxel opened this issue 2 years ago • 4 comments

Description

Add allow to create empty commit

Checklist

  • [x] Add test cases to all the changes you introduce
  • [ ] Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
    • One error on create commit message seem to be here before
  • [x] Test the changes on the local machine manually
  • [ ] Update the documentation for the changes
    • Not needed

Expected behavior

Allow to invoke cz and create a commit without any change in it

Additional context

Relates to #247 & #590

Dranaxel avatar Sep 18 '22 20:09 Dranaxel

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (92b1e89) 98.32% compared to head (a4c9a1e) 98.33%. Report is 401 commits behind head on master.

:exclamation: Current head a4c9a1e differs from pull request most recent head 4f9c725. Consider uploading reports for the commit 4f9c725 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #592   +/-   ##
=======================================
  Coverage   98.32%   98.33%           
=======================================
  Files          39       39           
  Lines        1614     1618    +4     
=======================================
+ Hits         1587     1591    +4     
  Misses         27       27           
Flag Coverage Δ
unittests 98.33% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 18 '22 20:09 codecov[bot]

@Lee-W Can you elaborate about what bother you in this test case ?

Dranaxel avatar Sep 21 '22 14:09 Dranaxel

I'm kinda not sure whether this is correctly tested and will need sometime to figure it out. Will try to check it this week

Lee-W avatar Sep 22 '22 02:09 Lee-W

Hi, I think we have a misunderstanding here. When I say "Empty commit" I mean a commit with no changes in it but we still need a message inside.

Dranaxel avatar Sep 27 '22 08:09 Dranaxel