Leda

Results 17 comments of Leda
trafficstars

Commit ffc0b77ffbaeb03f2aba010b8a8f3eca6e6001fd, showcases how case 2 would be fixed (replace `10px` with `env(safe-area-inset-bottom)`) Preview: ![image previewing message box](https://user-images.githubusercontent.com/38331868/172061291-4e6d2079-1e79-47fd-b923-06ce4bde464a.png) ![image previewing bottom navigation](https://user-images.githubusercontent.com/38331868/172061310-45311a19-c9a1-4695-b8e5-bcc58b56c683.png)

> This would probably need some sort of media query in the React code. @insertish, I am not sure how that would work because the hiding and showing of BottomNavigation...

@insertish, tried to reproduce this, but couldn't. ![showing text channel loaded with message content smaller than window height](https://user-images.githubusercontent.com/38331868/172020392-1653caa7-fe74-447c-bebc-b13bda7d5300.png) seems fine? (unless I misunderstood the issue description)

this is because the ImageViewer is now using the UI library https://github.com/revoltchat/revite/blob/a190a51d0b597370e66de96f7c94592debb7705c/src/context/intermediate/popovers/ImageViewer.tsx#L6 the old modal component had the following (which listened for "Escape" key clicks): ```js useEffect(() => { if...

Fixed in 0d3f29515e3ec8f1aab179914aa6634d323b2ded, [ImageViewer](https://github.com/revoltchat/revite/blob/f79288826849d0a6e64cb4e1e85b2830ccecc47b/src/controllers/modals/components/ImageViewer.tsx) now uses [ModalController](https://github.com/revoltchat/revite/blob/f79288826849d0a6e64cb4e1e85b2830ccecc47b/src/controllers/modals/ModalController.tsx) which depends on [ModalRenderer](https://github.com/revoltchat/revite/blob/f79288826849d0a6e64cb4e1e85b2830ccecc47b/src/controllers/modals/ModalRenderer.tsx#L13-L14) that has the following: https://github.com/revoltchat/revite/blob/f79288826849d0a6e64cb4e1e85b2830ccecc47b/src/controllers/modals/ModalRenderer.tsx#L13-L14

I can't really think of a way that won't change the way animating is currently handled, so if we're changing that, one option would be making the `MessageRenderer` hold values...

> This is likely an issue with markdown-it. Can confirm, using https://markdown-it.github.io/

I believe the issue is in line 375 https://github.com/revoltchat/revite/blob/a190a51d0b597370e66de96f7c94592debb7705c/src/pages/settings/server/Categories.tsx#L375-L392 where the `input` element goes back to a `span` if `editing` (which holds the current category title) is falsy, and an...

Changing line 375 from `editing ?` to `editing !== undefined ?` solves the issue, but it makes it possible to submit an empty string as a category name which is...

Replacing the current `save()` function https://github.com/revoltchat/revite/blob/a190a51d0b597370e66de96f7c94592debb7705c/src/pages/settings/server/Categories.tsx#L345-L348 with the following: ```js const save = useCallback(() => { setEditing(undefined); if (editing !== "") { setTitle!(editing!); } }, [editing, setTitle]); ``` solves the...