Leda comments

Results 17 comments of


                                            Leda

trafficstars

bug: Rejoining a server after being kicked does not update the member list

Can't reproduce (tried it with nightly, and production), can you provide steps? Below are the lines executed after server join https://github.com/revoltchat/revite/blob/67c8418c31a661bda82cb3ff728a80bd8dfcb7d4/src/pages/invite/Invite.tsx#L164-L174 specifically line 168, which doesn't differ from navigating to...

bug: Rejoining a server after being kicked does not update the member list

It seems that this only happens if the InviteEmbed is used, it doesn't happen if you join through URL these commits seem to be related https://github.com/revoltchat/revite/commit/fc91a75acb48c85179c1387d50a05e8377ac390b https://github.com/revoltchat/revite/commit/1089651cb03033ac278458dbff697644ce33f331 there is a...

profile settings bugs

this seems to be fixed? I tried: "", "˅" (nickname) and: "ʫʫʫʫʫʫʫʫ", "" (password) and they all worked with no complaints.

Specify that it's a new password when resetting password

The issue seems to be in https://github.com/revoltchat/revite/blob/12b97160433151c188b077bd3e85fc2ee35bbd99/src/context/intermediate/popovers/ModifyAccount.tsx#L113-L123 where the type specified (`password`), is used to target `login.enter.password` (currently is "Enter your password.") https://github.com/revoltchat/revite/blob/12b97160433151c188b077bd3e85fc2ee35bbd99/src/pages/login/FormField.tsx#L34-L39 and in order to change the placeholder...

Navigating directly to settings from outside the client then exiting will return user to previous page

@insertish wasn't this fixed in [~~5a49bc7~~](https://github.com/revoltchat/revite/commit/5a49bc7d20ea9253c86caea96bdc1ef8e7a5cee2) [271a126](https://github.com/revoltchat/revite/commit/271a126a3fc43cae914759839b13f0ef54de8029)?

feat: use appropriate placeholder text when changing password

> Conflicts with master, not sure if anything broke from a glance. The cause seems to be #650, specifically [`41e533a` (#650)](https://github.com/revoltchat/revite/pull/650/commits/41e533ab59ef2f32554632e417ffff6b1ad31cca) (ModifyAccount.tsx) and [`68b9d5e` (#650)](https://github.com/revoltchat/revite/pull/650/commits/68b9d5ea797e7acc15e065a04ac3f7f9bfa9fd3d) (FormField.tsx)

fix: display server identity (if present) in typing indicator

Memory usage looks stable, #### 1 Iteration aa9974149cb4cd86ee9b53b2582cb116bc5cc1c3: `8.117MB` to `8.162MB` (0.045MB), 7.980MB (-0.182MB) after garbage collection. (nightly) 7f5a7aec8689c329fa970e1eecddba7c3ccfa398: `8.050MB` to `8.095MB` (0.045MB), 7.967MB (-0.128MB) after garbage collection.