Lloyd Fournier comments

Results 280 comments of


                                            Lloyd Fournier

Descriptor policies should tell you which signers are used in satisfaction

Awesome would be really interested to see what you come up with here since I want to have it in `bdk_core`. What do you think about the idea about being...

Descriptor policies should tell you which signers are used in satisfaction

@danielabrozzoni my idea was that BDK would use this internally when computing the weight for coin selection so we didn't just use `max_satisfaction_weight`. I guess advanced users should be able...

Add IndexedChain trait and implement for Esplora & Electrum

FWIW my plan is **not** to merge this PR or something similar but rather to reduce the surface area that the main BDK lib has with blockchain interactions. I have...

AddressIndex improvements: LastUnused, FirstUnused, and get_batch_unused_addresses()

approach ACK. Needs rebase.

AddressIndex improvements: LastUnused, FirstUnused, and get_batch_unused_addresses()

IMO this PR is suboptimal because of #701. I think it should be fixed first to make the code in this PR make sense. @nickfarrow?

Use the new `script_sync` logic for RPC backend

Thanks for the detailed explanation @rajarshimaitra. > That's interesting. Though I don't want to build another custom sync logic just for RPC because that will break all those "unifying" points...

timestamp timelocks are not satisfied

Sure. To do this strictly correctly you need to know the "median time past": https://github.com/bitcoin/bitcoin/blob/a4e066af8573dcefb11dff120e1c09e8cf7f40c2/src/chain.h#L290-L302 I think an implementation on latest block timestamp would be better than nothing though?