Lloyd Fournier
Lloyd Fournier
ACK f965f95721c719ac755da07aa997d9b858583856
I did a lot of thinking about this. ## Backwards compat ```rust /// Persists an append-only list of changesets (`C`) to a single file. #[derive(Debug)] pub struct Store { magic_len:...
I later realized the "Forwards Compat" bit is not totally sound. Before trying to do a decode on a higher versioned entry you need to actually check it is higher...
I'd like to know what @nymius and @evanlinjin actually think about whether it's a good idea to actually do this. Before I speculated about how to this but didn't really...
Let's close this for now then. Please see https://github.com/bitcoindevkit/bdk/pull/1661 which documents the state of `bdk_file_store`.
I think this would be a good idea. I'd start by structuring the output for each command into types. Then have a `-j` flag that outputs everything in json. If...
> 2\. Fee here is for absolute fee and fee rate (you can't calculate fee rate without absolute fee). It's necessary for "fee calculation" because tx inputs do not contain...
> Seems to be isolated to the `CheckPoint` type, but the question remains whether something should be done in `bdk_bitcoind_rpc` to mitigate it > > ```rust > #[test] > fn...
I think this is the solution: https://github.com/bitcoindevkit/bdk/pull/1731. Perhaps that's already what you had in mind? I don't think this drop implementation could cause a performance issue. can you test that...
I wonder what we think about: ``` indexer.rs // the trait in here indexer/ ├── keychain_txout.rs └── spk_txout.rs ```