Felix Krause

Results 165 comments of Felix Krause

Hey @lolgear, sorry I completely missed this. I have notifications turned off for most GitHub repos. I'd be more than happy to hand you over the TSMessages main repo itself....

Thanks for this pull request. @mRs- @forgot I don't think the TSMessages library should required AVFoundation. Instead how about putting the sound support in a sub spec? What do you...

@forgot Thanks, yep, the pod spec looks fine. But I guess the code also has to be adapted: you can not include or call AVFoundation related code.

Yes, I guess it's not that easy. Maybe it would be interesting to add a delegate protocol for the messages, which can also be used by developers to do something...

Wow, that looks amazing. Thanks for your great contribution. I wonder why there was never a request for sound for messages - it's kind of obvious.

Yes, there is a milestone for that, containing a few issues: https://github.com/toursprung/TSMessages/issues/milestones/1/edit

I like the idea, but TSMessages is not in active development unfortunately. Also, the method headers are a big pain, as there are so many parameters already. This would all...

Sorry, I wanted to do that, but never found the time to. I don't know about good alternatives out of the top of my head.

Kind of fixed with https://github.com/KrauseFx/MajorKey/commit/155ddef418cc75081c968fc93b5d4d285fe63601 But need to add automatic re-try system

Yeah, I only have an iPhone X, so I'm not gonna fix that (haha, I'm such a nice contributor), but that's why the app is open source, do you want...