TSMessages
TSMessages copied to clipboard
KrauseFx
is this repository active?
@KrauseFx maybe we should search a new repo master for this. Unfortunately I don't have the time for this right now :(
I did search for a long time, but nobody wanted to take over. Let me know if you find someone.
Hey @KrauseFx can I take over the repo? Well.. to be more clear I kind of already forked the library and created a pod for my own version of this Library. Please see here --> https://github.com/donileo/RMessage. I took about two days doing the following: Refactoring the code to be more clean Doing various bug fixes on the library such as the notifications not centering properly when a navigation controller was shown Removing the bad blur code as well as adding more customization keys such as opacity and separating title and subtitle shadows. Uses Autolayout
Hope renaming the library and making the above changes isn't bad with you and I do plan on noting in my Readme that the code is originally based on TSMessages though I did change various things around.
Took a first look, seems fine to me. Do you have a full history of your changes?
Im going to have cook one up for you guys. I initialized a new git history for my project since I wanted to kinda start from new so its not a perfect/true fork in the sense.
Given the nature of github et al, it would make sense to give credit to this git on main page of RMessage.
@wdcurry thats perfectly fine with me.. Just havent gotten around to updating the Readme too much :), been busy updating and refactoring a bunch of other stuff in the library.
Thanks @donileo for taking it over, I just update and it was an easy task.
@KrauseFx I recommend you to update the repo README pointing out to RMessage as an uptodate option to TSMessages.
@mRs @KrauseFx I think you guys wanted a diff between RMessage and TSMessage. Feel free to do a git diff across TSMessages and RMessage.
Hey @lolgear, sorry I completely missed this. I have notifications turned off for most GitHub repos. I'd be more than happy to hand you over the TSMessages main repo itself. It's used by more than 10,000 apps via CocoaPods: https://cocoapods.org/pods/TSMessages
I'll grant you commit access, and we can move the repo into its own org if you'd like 👍
One key requirement is to not break any existing setups, it should stay backwards compatible.
@KrauseFx Thanks. Yea, definitely, maintaining backwards compatibility is definitely of great importance. Currently, the only feature RMessage doesn't have is the ability to use a UIButton as the notification view/image in the message itself, though that will be included shortly in the future. Considering I'm sure many people are using TSMessages without issue (or many issues :)) I'm thinking the correct thing is to get people to transition to RMessage as they see fit by putting it in the README of this repo. Thoughts? As far as moving this repo into its own org (I'm assuming you mean organization) what org would that be?