Baptiste Leduc comments

Results 134 comments of


                                            Baptiste Leduc

report the actual validation errors when logging validation error

Thanks a lot for your contribution. You will need to regenerate tests fixtures for the tests to pass. To do so you have to run the tests locally, they will...

report the actual validation errors when logging validation error

Thanks for your fix @dbu !

[OpenAPI] Handle parameters key as parameter name

Made some tests to implement this issue, actually it is not possible to do it since keys are stripped during schema denormalization. We will have to modify the source OpenApi...

Jane generates multiple model classes for one given entry in the schema

Sadly we do not support `allOf` / `oneOf` fields atm, but I know there was some work started for `oneOf` with #486 For `allOf` it's a bit more complex since...

since symfony 5, Length with min option allows empty string

Thanks for contributing @dbu !

Middleware support for endpoint response processing

Hey @FilipBenco, Why the `endpoint-generator` is not good anymore ? I don't think something changed with the Generator refactoring, or maybe I'm wrong ?

Middleware support for endpoint response processing

Ok, I get your point. I'll try to think how this can be done the best way, not sure having some middlewares is the best thing to do since it...

findUrlFactory used by the ServerPluginGenerator is deprecated.

Thanks for reporting this issue :+1: Feel free to open a PR if you have time, base yourself onto `6.3.x` branch for this kind of fix :wink:

Generate constants for enum properties

This is a really cool idea ! I will try to make it work for next minor :+1:

Generate constants for enum properties

Hey @HEKET313 Sorry, I'm actually more focused on Validation behavior #405 (introducing a new JSON Schema spec into Jane). I do need this "Validation" before generating theses enums because the...