Baptiste Leduc
Baptiste Leduc
> Open for finishing the first docs? Sorry for the delay, I made some changes and will try to find time to fix the remaining parts.
Hey there, @javiereguiluz any news ?
Hey @AurelienPillevesse , thanks for your PR ! But isn't that what `skip-null-values` does already ? See: https://github.com/janephp/janephp/blob/next/src/Component/JsonSchema/Generator/Normalizer/NormalizerGenerator.php#L120-L126 ```php if ((!$context->isStrict() || $property->isNullable() || ($property->getType() instanceof MultipleType && \count(array_intersect([Type::TYPE_NULL], $property->getType()->getTypes()))...
Could we do the same you did by adding an option ? I would prefer that to avoid issues with existing users :pray: Something like `skip-null-values-no-check` ? Not sure if...
> I have updated my PR, I just didn't find how to run the test. Is it the file `src/Component/OpenApi3/Tests/JaneOpenApiResourceTest.php` ? You have to run the whole suite each time...
Sorry for the delay, I just merged and tagged a new version: https://github.com/janephp/janephp/releases/tag/v7.6.1 !
Any news on that PR ? I would love to merge this soon :pray:
I just tried to make this change and this is clearly not a trivial fix. I will close this PR as it was abandoned.
Thanks for you report, validating date formats is a really good idea indeed ! I'll try to add that when I have time !
Hey @vaidas-lungis, any update on this ?