KonradRudin

Comments on the flight tests: - Generally, the vehicle does not completely reach the maximum airspeed but it is a bit slower (in the flight test reaching 21.5m/s instead of...

Also for discussion if we really want this commit in https://github.com/PX4/PX4-Autopilot/pull/22479/commits/f3ccd18e15b6ceeaa357c0aca46e82a868d904f1 This would allow for higher values when the altitude and airspeed errors are not distributed evenly. But it helped...

> > it is checked again before the mission is executed and a geofence violation is caught at that time (though you don't have immediate feedback in QGC). > >...

> > but then you should reflect this evaluation in the mission result uorb topic as its done here https://github.com/Drone-Lab/PX4-Autopilot/blob/5490f8913bd26ac04d59908271ce9c5e6a1bd414/src/modules/navigator/mission_base.cpp#L702-L707 such that it is not run again by the mission...

Sorry, was away last week. So basically we need to make sure that the geofence module has already properly loaded the geofence data before we can test for it right?

> Alternatively, add a check after successful upload? You mean after successful loading into cache i presume? Yes, as a first step we can force it to check again after...

> what's the further plans? making geofence sync read and adding locks or semaphores? No, the caching is fine. But the geofence should be more a service module as well...

It depends on your timeline. I also would like to improve the mission feasibility checks a bit and make it independent of the mission, but i won't have time right...

> The other thing you could do is only update it here if not moving. And how would you do that? Alo check on the velocity? Could still lead to...

Also here for completeness a plot from the home position changes before this PR, you can see, that the home position does change several times although the vehicle did not...