Ashley Mannix

Results 389 comments of Ashley Mannix

Hi @glandium :wave: Thanks for the PR! I can appreciate the need to manage logging at a finer grained level than the final binary, but am hesitant to encourage spreading...

It's been a little while now, since we weren't looking to dig deeper into Cargo features I'll go ahead and close this one, but I hope you found your way...

Interesting! Is this still the case today? I’m guessing that’s coming from these checks? https://github.com/rust-lang/log/blob/master/src/macros.rs#L34 I wonder if that’s got anything to do with the `PartialOrd` impl being non-const? It...

Thanks for the PR @Cassy343! I think one of your earlier points about not using a home-grown once cell for this is pretty valid, and once [`OnceLock` stabilizes](https://github.com/rust-lang/rust/issues/74465) we should...

@Thomasdezeeuw unfortunately it’s a limitation of Cargo features. Since it’s not possible to activate a feature of a dependency when two unrelated features are active we need one that covers...

@Thomasdezeeuw we can do that in code, but we also have dependencies that need their own `std` features enabled too.

@Thomasdezeeuw Will do! I'll get the ball rolling on this now.

@Thomasdezeeuw I've been waiting for some feedback from the wider project on https://github.com/rust-lang/log/issues/343#issuecomment-1002851191, but it's been a bit quiet. I'm pretty confident in the direction we're going though and that...

I've opened #485 to get a release out the door. I'm just going to run through the diff, but if you had a chance to take a look too @Thomasdezeeuw...

Thanks for your patience and for working on this one @jelmansouri! It's a bit unfortunate that ```rust info!(target: static_str(), "Some message"); ``` won't produce a static target, since it won't...