Ashley Mannix

Results 389 comments of Ashley Mannix

This would be a nice bit of gardening if anybody would like to tidy up the example blocks!

This seems like a reasonable amendment to me. We should probably include some description of what an _aggregate_ is so users browsing the guidelines know we're talking about `enum`s or...

We’re still getting an idea of what kinds of amendments need to run through an FCP or not. On a second reading, this update seems reasonable and uncontentious enough to...

We could link to other guidelines suggesting appropriate traits are implemented from this one, which I think should cover ensuring a newtype is appropriately usable.

We should try be more direct on _where it makes sense_. My thoughts are: - `From`: For infallible generic conversions. If you have a type `T` that you might want...

It would be great to add some concrete guidance here. It looks like we never got back around to that postponed RFC but [its content should make a good starting...

:+1: For better discoverability. Do you think maintaining a separate list of the issues with summaries would be better than a link to an issue filter with a summary maintained...

Hi @ultrasaurus :wave: Welcome to the community! We've been a bit quiet on this repo for a while, but are starting to try revive some discussion. We've enabled [GitHub Discussions](https://github.com/rust-lang/api-guidelines/discussions)...

Hey @commonsensesoftware :wave: I haven't actually looked much at tool packages but it looks like they follow the same structure, but have this extra bit of metadata in the `nuspec`:...