Ashley Mannix

Results 389 comments of Ashley Mannix

My own opinion on this is that if you don't have a lock file then you shouldn't be concerned with MSRVs. As far as real utility is concerned they're ceremonious...

@rfcbot fcp merge This suggests a guideline that smart pointers inherit the `Debug` implementation of their pointee.

This seems like an amendment we'd want to make now. In the intervening years I think PascalCase has emerged as a standard for type macros (like [`syn::Token!`](https://docs.rs/syn/1.0.55/syn/macro.Token.html)).

@rfcbot fcp merge This proposes amending our naming conventions to recommend type macros use PascalCase naming instead of snake_case.

cc @rust-lang/project-error-handling This guideline deals with implementations of `Display` for `Error`s with respect to their implementation of `Error::source`.

You don't technically need to use the `IntoIterator` trait in order to work with `for` loops (it just expects an `into_iter` method), but we don't actually appear to have any...

We should probably also mention implementing `IntoIterator` for `&Self` and `&mut Self` too that mirrors the inherent `iter` and `iter_mut` methods.