Tomasz Chabora
Tomasz Chabora
Can't reproduce in 4.0 stable. No crash with the given code.
Ok I can reproduce the crash in official build, but it does not happen in dev build 🤔
Looks good overall, but I'm not convinced about adding another member to PropertyInfo (the `property_dependency`). I wonder if it couldn't be part of `hint_string`, like just add it after some...
Not really. I forwarded this PR on [RocketChat](https://chat.godotengine.org/channel/core), you can join to discuss it (it would be faster than waiting for a comment in the PR).
Crash log ``` CrashHandlerException: Program crashed Engine version: Godot Engine v4.1.dev.custom_build (60fefcf8527ed57c82d957c480871fe7fd6a11f3) Dumping the backtrace. Please include this when reporting the bug to the project developer. [0] Node::get_node_or_null (C:\godot_source\scene\main\node.cpp:1272) [1]...
This is intended behavior. If you don't like it, open a [proposal](https://github.com/godotengine/godot-proposals). (or just disable the warning I guess)
Hmmm, now that I think about it, TilesEditorPlugin was a hack to allow 2 editors at once, but it's no longer necessary probably 🤔 Removing it might fix some bugs.
Ok done. TilesEditorPlugin now handles some singleton things, but otherwise all editing is done by TileMapEditorPlugin and TileSetEditorPlugin. I had to resort to some *tricks* to make everything work correctly;...
But the class does more than just synchronizing, so if anything, it needs a better name.