KnightNiwrem

Results 9 comments of KnightNiwrem

Is it only fixable in a major release because of public API changes to session? Would the use of mutex be overkill here?

@KnorpelSenf @yrzam It seems like this might no longer be an issue for later versions of grammY/typescript. At least, with the given snippet and tsconfig, there are no tsc build...

Adding https://t.me/grammyjs/235195 as a point of consideration. Given potential use cases where one might try to call halt or exit inside the conversation function, but through a plugin; it raises...

> @KnightNiwrem you're still working on this, right? Yes

> This is mostly working as intended for horizontally scaled setups (if I recall correctly): > > * (to a shared volume / storage location) That's fair. Then we are...

> This [line](https://github.com/grammyjs/grammY/blob/9aed1336afdc4bec4b77751df07c82617a05e120/src/convenience/webhook.ts#L142-L147) looks very strange. > > if (header !== token) { > await unauthorized(); > // TODO: investigate deno bug that happens when this console logging is removed...

Technically, `type MyContext = Context & CommandsFlavor` is equivalent to `type MyContext = Context & CommandsFlavor`, since `CommandsFlavor` provides a default `Context` type where the parameter type is not given...