grammY icon indicating copy to clipboard operation
grammY copied to clipboard

fix: avoid top-level await

Open KnorpelSenf opened this issue 1 year ago • 1 comments

Dropping the only instance of TLA

KnorpelSenf avatar Mar 22 '24 11:03 KnorpelSenf

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.08%. Comparing base (c79df4a) to head (018210c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   46.08%   46.08%           
=======================================
  Files          19       19           
  Lines        6052     6052           
  Branches      320      320           
=======================================
  Hits         2789     2789           
  Misses       3260     3260           
  Partials        3        3           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 22 '24 11:03 codecov[bot]

This is more complicated than I thought, and the benefits are small. I will abandon this.

KnorpelSenf avatar Apr 15 '24 09:04 KnorpelSenf

What happened?

KnightNiwrem avatar Apr 15 '24 12:04 KnightNiwrem

TLA is not supported on all platforms, querySync is not supported on all platforms, and if we migrate to JSR, we will have to unify all the platform-specific code anyway. I don't see a lot of value in figuring out a good short-term solution here.

KnorpelSenf avatar Apr 18 '24 21:04 KnorpelSenf