Yuan Chang

Results 13 comments of Yuan Chang

Seems moved to [PYSIDE-1344](https://bugreports.qt.io/browse/PYSIDE-1344).

> Could you actually implement the Float trait for an ndarray? You seem to have provided implementations for most if not all of the required methods. The main reason is...

> What requirements are you talking about? Oh, I mean the functions should be implemented with the `Float` trait.

Additionally, I think there should be add a `#[must_use]` notation, same as the standard library. ```rust #[must_use = "method returns a new array and does not mutate the original value"]...

> Same as last time: "this PR is waiting on updates from the author" > > Since this MR has been discussed and reviewed, I wouldn't mind merging it if...

> @KmolYuan What about the `clamp` function? Shouldn't we use the one from std? > > clamp is stable since 1.50 and the minimum Rust version in this project is...

There might be some tricks about the program side than user interface. Technically, two line elements can use same point element as theirs joint without "same point" constraint. And some...

@henrikh I was actually re-disigned a [new wrapper](https://github.com/KmolYuan/python-solvespace/blob/master/Cython/slvs.pyx) with Cython. And the SWIG wrapper might be deprecated after new wrapper has fully tested. The structure that exported in wrapper: https://github.com/KmolYuan/python-solvespace/blob/master/Cython/slvs.pxd#L90-L103...

Sounds like a nice feature. But now the source code is not the latest version. Based on problem-solving needs, I will try to add it.

Thanks for your work! But isn't sdist build require an external C compiler installation? Building for different platforms lets elementary users can install the package directly.