Alex King

Results 40 comments of Alex King

Could we fix this by adding a `spell_rank_groups` table and at least putting the default ranked spells groups in there so we can have a way to separate the ranks?...

> I think this could be fixed by not adding a new table. Just need to check if the spell has a rank and find the previous already mem'd rank...

Ah gotcha, wasn’t aware that column was used for that. Sounds like something easy to fix though.

> I have been testing this and have seen a few crashes (Note my line numbers wont line up to master) > > ``` > #0 0x00007f67bfbfa0ca in __waitpid (pid=787296,...

May have to try this post-#date fix to see if you get the same results.

Is this something we’re going to move forward with, or is it something we should wait until the future for? Can close and reopen in the future maybe?

I would set the default to -1 and check if the rule value is greater than 0 when checking if you should use the cap. As-is, the cap is force...

> Another one almost a month now, @hgtw @Kinglykrab what is the consensus here Looks fine to me. @mackal mentioned adding Live-like formula, but think that's outside the scope of...

Have any steps to replicate this so I can test? Never seen myself go under world as described.