Server icon indicating copy to clipboard operation
Server copied to clipboard

Published 20 hours ago • verified publisher icon EQEmu

[CPP] Update submodules

Open mackal opened this issue 2 years ago • 2 comments

fmtlib has some breaking changes, do later

mackal avatar Jul 13 '22 20:07 mackal

Was this tested thoroughly in game?

I got in game and ran around did combat etc

mackal avatar Jul 14 '22 18:07 mackal

I'm hesitant of just version bumping all of these without testing their related surface areas more closely. It seems like a simple change to bump but for some its been a while and we can definitely be burned.

This would be going in between a lot of other changes too and sometimes needle in the haystack can be really hard to pin down so would at least like to know master is stable before we bump as well

Akkadius avatar Jul 15 '22 02:07 Akkadius

Is this something we’re going to move forward with, or is it something we should wait until the future for? Can close and reopen in the future maybe?

Kinglykrab avatar Aug 19 '22 11:08 Kinglykrab

I think it would be best to just update everything and keep on track better making sure we don't go years out of date.

mackal avatar Aug 19 '22 14:08 mackal

I think it would be best to just update everything and keep on track better making sure we don't go years out of date.

If you're willing to be ready to deal with unexpected aftermath, we can get it staged on PEQ

Akkadius avatar Aug 20 '22 08:08 Akkadius