René Kijewski

Results 130 comments of René Kijewski

Thank you for providing the installation log! I did not provide the pre-compiled version for your system, and the compilation fails for some reason. I just uploaded pre-compiled versions for...

> sorry, stupid question surely, but how can I check that? 🙏 > > so far I was just trying to install the lib through a poetry install I never...

> Can you make this a pair of features to enable either ureq or reqwest? Yes, that would have been a good idea from the get-go. Will do, but I...

Can you please restart the checks? It looks like the runner had a problem, not the code.

So, 3 out of 4 commits are now unrelated to the title of the PR. Should I move them into a new PR, or do you not mind?

I'd propose to simply remove `@let variable;` patterns. You can always refactor your match statements to return a tuple, so that all variables are assigned afterwards.

Alas, windows-core 0.54 is not backward compatible to 0.52. And the generated code in Windows.rs uses edition 2021 features. So, we can either 1. stay with the old windows-core version...

Are there open questions left?

Hey @zweibieren, please have a look at an old comment by me: https://github.com/nmaier/mod_xsendfile/issues/22#issuecomment-182393654

> Do you know if we have managed to not expose any of the underlying implementation details such that this can be considered backwards compatible? I code it fully self-contained....