René Kijewski

Results 102 comments of René Kijewski

Thank you for your work! I created a PR against your PR with a few suggestions: https://github.com/11Tuvork28/askama/pull/1

Sorry, https://github.com/11Tuvork28/askama/pull/2 is a bit huge again, but I guess it's worth it: Check if the addressed messages exists, and if the right arguments were used, at compile time.

Sorry, I hope https://github.com/11Tuvork28/askama/pull/3 is the last PR :/

You wrote `{% include %}` when you wanted to use `{% extends %}`: https://djc.github.io/askama/template_syntax.html#template-inheritance `{% include %}` in Askama is just like `#include` in C: The source of the included...

You are describing exactly what `{% extends %}` does. Maybe Jinja2's readme is more clear to you? https://jinja2docs.readthedocs.io/en/stable/templates.html#template-inheritance

I don't know why this restriction exists. Maybe you could comment out https://github.com/djc/askama/blob/0b376b439f759613966916787b613616627bb3f9/askama_shared/src/generator.rs#L445-L447 and tell us what works and what breaks then?

`t.token.get(0..10).unwrap()` would work. The problem is not the slice syntax, actually, but the ampersand is not an operator in Askama.

In https://github.com/djc/askama/blob/082a9c2db9bb128956dd70f146af3e0228e4c433/askama_shared/src/input.rs#L225 we strip off Jinja2 extensions. Maybe we could make this list extensible or add ".askama"?

Please have a look if building a tuple as in [this test](https://github.com/djc/askama/blob/da0b6ead0e75082bfffa24f8529d1f83961ba45c/testing/tests/tuple.rs) would work for you. To me it feels much more rust-y and jinja-y than a `{% contentcheck %}`...

Please have a look at jannik4/askama#1. You don't need to add explicit lifetimes in all these places.