René Kijewski

Yeah, but you should comment on the existing PR instead of opening a new issue, or the discussion will become cluttered. @antonha would probably be happy about your input.

No, I'm still using the old ES version because of that. IMO this plugin is essential and should be adopted into the core. :-/

It is impossible to determine what enum/struct type the value is. E.g. ```rust match x.try_into() { Ok(_) => …, Err(_) => … } ``` only compiles, because the prelude contains...

Maybe we could emit `#[warn(unreachable_patterns)]` in the generated code? Won't break existing code, but at least warn the user that something might be off. I haven't tested if the explicit...

Nope, not even `buf.writeln("#![forbid(unreachable_patterns)]")?;` in `generator::impl_template()` works.

That's a good idea! Especially because my current squashing workflow breaks `git blame`. I will use a submodule for future commits

> Also, why not go with the ux crate or the arbitrary-int crate? Neither crate uses niche optimization. I have an open PR for ux to implement it there: https://github.com/kjetilkjeka/uX/pull/49....

> If we're going to do this, why not take the 15-bit niche from secs instead of 1 bit from frac? In my current implementation, if the last bit of...

> The compiler is allowed to reorder fields at will, right? Why wouldn't it do so here? And if not, we can trivially reorder secs and frac within NaiveTime. I...

nonmax generates terrible byte code, because it has to negate the value on every access. Most likely twice: once for reading, once for writing. This is enough to make the...