Kevin Robatel
Kevin Robatel
What about using `Number`? ``` fun Number.toDp(context: Context): Float { if (this == 0) return 0f return TypedValue.applyDimension( TypedValue.COMPLEX_UNIT_DIP, this.toFloat(), context.resources.displayMetrics ) } ```
> I have honestly no idea how to add testing and how to perform it :/ You can add it to `PrivateCacheTest` and `PublicCacheTest` in `$cacheProviders` like `FlysystemStorage` 👌
Hello! I didn't tested this library with Guzzle7 at the moment. I don't have time these days for that. If you find something, don't hesitate de make a PR.
You can use [`ChainCache`](https://github.com/doctrine/cache/blob/1.11.x/lib/Doctrine/Common/Cache/ChainCache.php) for using multiple cache storage. But we can change for checking the presence of the header before setting it! Would you like to make a PR...
Thank @mpdude for this PR! I will take some times for checking it 👍 Can you please rebase or merge `master` into your branch? I have adapted the Github Action...
> Obviously I'll need to update the tests to reflect changed behaviour; will do once we basically agree. I think the logic is good like that! Can you adapt the...
Are you sure that this is this middleware that cause the issue? The `sink` option is handled before this middleware. Can you share/post your code?
I thing that this is right. We should change the logic.
Hi, Are you sure that the `delay` impact the response from the cache? I looked into the source of Guzzle and I thought that it only delay the real call...
@afoeder The RFC said that we have to add a `Warning` header in the response in some situation. By example: `Warning: 110 - "Response is Stale"` for a stale response....