guzzle-cache-middleware icon indicating copy to clipboard operation
guzzle-cache-middleware copied to clipboard

Add Flysystem 2 Storage

Open marcus-at-localhost opened this issue 4 years ago • 8 comments

marcus-at-localhost avatar Feb 03 '21 15:02 marcus-at-localhost

Why are you using LocalFilesystemAdapter instead of FilesystemAdapter (Every adapter must implement the League\Flysystem\FilesystemAdapter interface.) says the doc?

I think we need an update to Flysystem 2.0

diego-sorribas avatar Feb 17 '21 19:02 diego-sorribas

Why are you using LocalFilesystemAdapter instead of FilesystemAdapter (Every adapter must implement the League\Flysystem\FilesystemAdapter interface.) says the doc?

I'm not 100% sure if that could be done differently. I just adjusted the existing flysystem implementation according to the docs. https://flysystem.thephpleague.com/v2/docs/adapter/local/

marcus-at-localhost avatar Feb 17 '21 20:02 marcus-at-localhost

Is this going to get merged?

marcus-at-localhost avatar Jun 26 '21 12:06 marcus-at-localhost

I have honestly no idea how to add testing and how to perform it :/

marcus-at-localhost avatar Jul 13 '21 14:07 marcus-at-localhost

I have honestly no idea how to add testing and how to perform it :/

You can add it to PrivateCacheTest and PublicCacheTest in $cacheProviders like FlysystemStorage 👌

Kevinrob avatar Jul 14 '21 10:07 Kevinrob

Changes can be based off https://github.com/dpi/dogit/pull/2/files#diff-807a9ba3b18ae226d5e918d14500c7503f96864c697a8d97a8fdb3396312ff97R19

dpi avatar Jul 23 '21 09:07 dpi

Apologies, I'm kind of lost, since this goes deep with the testing and my knowledge here is still rudimentary. Is it possible for someone else to add/merge those proposed changes so it passes all tests? I would really appreciate that.

marcus-at-localhost avatar Jul 27 '21 12:07 marcus-at-localhost

Flysystem 3 is now a thing ;)

dpi avatar Feb 19 '22 16:02 dpi