guzzle-cache-middleware
guzzle-cache-middleware copied to clipboard
Add Flysystem 2 Storage
Why are you using LocalFilesystemAdapter instead of FilesystemAdapter (Every adapter must implement the League\Flysystem\FilesystemAdapter interface.) says the doc?
I think we need an update to Flysystem 2.0
Why are you using LocalFilesystemAdapter instead of FilesystemAdapter (Every adapter must implement the League\Flysystem\FilesystemAdapter interface.) says the doc?
I'm not 100% sure if that could be done differently. I just adjusted the existing flysystem implementation according to the docs. https://flysystem.thephpleague.com/v2/docs/adapter/local/
Is this going to get merged?
I have honestly no idea how to add testing and how to perform it :/
I have honestly no idea how to add testing and how to perform it :/
You can add it to PrivateCacheTest
and PublicCacheTest
in $cacheProviders
like FlysystemStorage
👌
Changes can be based off https://github.com/dpi/dogit/pull/2/files#diff-807a9ba3b18ae226d5e918d14500c7503f96864c697a8d97a8fdb3396312ff97R19
Apologies, I'm kind of lost, since this goes deep with the testing and my knowledge here is still rudimentary. Is it possible for someone else to add/merge those proposed changes so it passes all tests? I would really appreciate that.
Flysystem 3 is now a thing ;)