Kengo TODA

Results 145 comments of Kengo TODA

I know one case, is that, Windows uses cache and it keep file handle opened by JVM. Then `URLConnection#setUseCaches(false)` is necessary to avoid this handler leak. In my understanding, SpotBugs...

I guess that we probably need a fix like this? Is there anybody can reproduce this issue? ```patch diff --git a/spotbugs/src/main/java/edu/umd/cs/findbugs/PluginLoader.java b/spotbugs/src/main/java/edu/umd/cs/findbugs/PluginLoader.java index f4112bb72..fbfe3c352 100644 --- a/spotbugs/src/main/java/edu/umd/cs/findbugs/PluginLoader.java +++ b/spotbugs/src/main/java/edu/umd/cs/findbugs/PluginLoader.java @@...

If you can reproduce this problem, try [this patch](https://github.com/spotbugs/sonar-findbugs/issues/128#issuecomment-500278033) and share the result if possible.

Could you take threaddump by [`jcmd` tool](https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/tooldescr006.html)? It's better to [take threaddump several times like this page](https://community.cloudera.com/t5/Community-Articles/How-to-collect-threaddump-using-jcmd-and-analyse-it/ta-p/248391), then we can compare them to grasp how threads were working.

Thanks. I found that the code is stacked around `FindbugsConfiguration.scanForAdditionalClasses()`: https://github.com/spotbugs/sonar-findbugs/blob/d5f03306b7543584eb23fbb3c6b41aefa9696bcb/src/main/java/org/sonar/plugins/findbugs/FindbugsConfiguration.java#L213-L229 I guess that we need to use [the FileVisitor](https://docs.oracle.com/javase/tutorial/essential/io/walk.html) or streaming API to be more lazy. ``` "main" #1...

> 14:13:21.445 WARN: Findbugs needs sources to be compiled. Please build project before executing sonar or check the location of compiled classes to make it possible for Findbugs to analyse...

> a) Do you mean that the plugin's scanForAdditionalClasses needs certain refactoring? Could you please explain why the thread may be getting stuck? I'm still working in [the branch issue-318](https://github.com/spotbugs/sonar-findbugs/compare/issue-318),...

@rngh101 I confirmed that the plugin itself is working, could you compare its performance with 4.0.0 in your env? You can build and install the plugin file like below: ```sh...

Really interesting, if we can handle backward compatibility well, it should be nice. :)

It seems that the discussion at that issue is still in progress, so I removed milestone from this issue.