Kengo TODA

Results 145 comments of Kengo TODA

SpotBugs core also depends on JSR305, so we need to remove it too.

> Given that the JSR305 annotations are used to annotation FindBugs/SpotBugs, doesn't it make more sense to take ownership and port these to a new namespace? Please send your PR!...

Note: JSR305 ri (reference implementation) is licensed under BSD-3-Clause. * https://github.com/amaembo/jsr-305/blob/master/ri/LICENSE

> Is there any way to continue development within the javax.annotations package? I know one solution: [TypeQualifierNickname](https://static.javadoc.io/com.google.code.findbugs/jsr305/3.0.2/javax/annotation/meta/TypeQualifierNickname.html). But it means that our implementation still needs to depends on `javax.annotation` implementation,...

> should we be coordinating with @amaembo then? No. Type qualifier nickname is a feature to handle annotation as nickname/facade for another annotation. For instance, [Nullable](https://static.javadoc.io/com.google.code.findbugs/jsr305/3.0.2/javax/annotation/Nullable.html) is nickname for [Nonnull](https://static.javadoc.io/com.google.code.findbugs/jsr305/3.0.2/javax/annotation/Nonnull.html).

So I thought that we can annotate our new annotations with `TypeQualifierNickname`, then tools can treat them as a nickname for JSR305 annotations.

As ThrawnCA said, we cannot make it sure which .java generates the target .class file. We can guess it based on package name and source directories (like SpotBugs GUI) but...

please provide enough information to reproduce this issue.

Thanks. Confirmed that it's reproducible with `3.1.0-RC1` ~ `v3.1.5`.

debug log: ``` [spotbugs] Executing SpotBugs FindBugsTask from ant task [spotbugs] Running SpotBugs... [spotbugs] Executing '~/oracle-jdk-1.8.0_121/jre/bin/java' with arguments: [spotbugs] '-Dfindbugs.hostApp=FBAntTask' [spotbugs] '-classpath' [spotbugs] '~/.ivy2/cache/com.github.spotbugs/spotbugs-ant/jars/spotbugs-ant-3.1.4.jar:~/.ivy2/cache/com.github.spotbugs/spotbugs/jars/spotbugs-3.1.4.jar:~/.ivy2/cache/org.ow2.asm/asm/jars/asm-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-analysis/jars/asm-analysis-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-tree/jars/asm-tree-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-commons/jars/asm-commons-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-util/jars/asm-util-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-xml/jars/asm-xml-6.2.jar:~/.ivy2/cache/org.apache.bcel/bcel/jars/bcel-6.2.jar:~/.ivy2/cache/net.jcip/jcip-annotations/jars/jcip-annotations-1.0.jar:~/.ivy2/cache/org.dom4j/dom4j/jars/dom4j-2.1.0.jar:~/.ivy2/cache/jaxen/jaxen/bundles/jaxen-1.1.6.jar:~/.ivy2/cache/commons-lang/commons-lang/jars/commons-lang-2.6.jar:~/.ivy2/cache/com.google.code.findbugs/jFormatString/jars/jFormatString-3.0.0.jar:~/.ivy2/cache/com.github.spotbugs/spotbugs-annotations/jars/spotbugs-annotations-3.1.4.jar:~/.ivy2/cache/com.google.code.findbugs/jsr305/jars/jsr305-3.0.2.jar' [spotbugs] 'edu.umd.cs.findbugs.FindBugs2' [spotbugs] '-pluginList' [spotbugs] '~/.ivy2/cache/com.github.spotbugs/spotbugs-ant/jars/spotbugs-ant-3.1.4.jar:~/.ivy2/cache/com.github.spotbugs/spotbugs/jars/spotbugs-3.1.4.jar:~/.ivy2/cache/org.ow2.asm/asm/jars/asm-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-analysis/jars/asm-analysis-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-tree/jars/asm-tree-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-commons/jars/asm-commons-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-util/jars/asm-util-6.2.jar:~/.ivy2/cache/org.ow2.asm/asm-xml/jars/asm-xml-6.2.jar:~/.ivy2/cache/org.apache.bcel/bcel/jars/bcel-6.2.jar:~/.ivy2/cache/net.jcip/jcip-annotations/jars/jcip-annotations-1.0.jar:~/.ivy2/cache/org.dom4j/dom4j/jars/dom4j-2.1.0.jar:~/.ivy2/cache/jaxen/jaxen/bundles/jaxen-1.1.6.jar:~/.ivy2/cache/commons-lang/commons-lang/jars/commons-lang-2.6.jar:~/.ivy2/cache/com.google.code.findbugs/jFormatString/jars/jFormatString-3.0.0.jar:~/.ivy2/cache/com.github.spotbugs/spotbugs-annotations/jars/spotbugs-annotations-3.1.4.jar:~/.ivy2/cache/com.google.code.findbugs/jsr305/jars/jsr305-3.0.2.jar'...