Ken Corbett
Ken Corbett
Can we merge this in? I really don't want to maintain a fork just so I can get this fix, but it is critical for this to work at all...
Ahh yes. I see. I fixed it to do the check again but without option chaining.
@dackers86 could you approve this pull request again?
What do I need to get this merged? It looks like I still need approval from @dackers86 but I already got approval.
Sure! I went ahead and removed those from this pull request.
I didn't think it would make a difference, but just to be sure I went ahead and re-ran all my tests and the file input works beautifully.
What additional testing needs to be done to get this merged in?
@ArturKp I would still love to get this done. I was busy for a bit, but I have some more time now and I think we are close to getting...
@jacobg how do they need to be revised?
I applied your code review feedback. Should I also add a request for camera permission? Or somehow check if the app already has that permission?