extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Allow firestore-counter to run on the emulator

Open KenCorbettJr opened this issue 3 years ago • 5 comments

When running firestore-counter locally and the counter is first starting there are not always workers in the controllerData. This update prevents an error in this case and allows the counter to start and function normally.

This is the error I was getting:

Screen Shot 2022-08-08 at 4 37 34 PM

After this update, I no longer get this error.

KenCorbettJr avatar Aug 08 '22 20:08 KenCorbettJr

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 08 '22 20:08 google-cla[bot]

Hi @KenCorbettJr

Thanks for the PR! It appears that the validator has an option with optional null values.

This may require an additional update, I've to our review column for any suggestions / future updates.

dackers86 avatar Aug 09 '22 14:08 dackers86

Ahh yes. I see. I fixed it to do the check again but without option chaining.

KenCorbettJr avatar Aug 16 '22 23:08 KenCorbettJr

@dackers86 could you approve this pull request again?

KenCorbettJr avatar Aug 19 '22 22:08 KenCorbettJr

What do I need to get this merged? It looks like I still need approval from @dackers86 but I already got approval.

KenCorbettJr avatar Sep 02 '22 23:09 KenCorbettJr

I changed the base of this PR -- all new changes need to go into next.

pavelgj avatar Oct 17 '22 17:10 pavelgj

Hi @KenCorbettJr

Apologies for the delay on this one, there are some conflicts and files changed unrelated to the PR.

We are currently looking into adding a better testing environment for this Extension.

We'll look to patch up and add this PR with the testing environment for the next release.

dackers86 avatar Jan 11 '23 10:01 dackers86